plat/marvell: Migrate to multi-console API
authorKonstantin Porotchkin <[email protected]>
Wed, 14 Nov 2018 15:15:08 +0000 (17:15 +0200)
committerKonstantin Porotchkin <[email protected]>
Thu, 15 Nov 2018 11:42:45 +0000 (13:42 +0200)
Migrate Marvell platforms from legacy console API to
multi-console API.

Change-Id: I647f5f49148b463a257a747af05b5f0c967f267c
Signed-off-by: Konstantin Porotchkin <[email protected]>
16 files changed:
drivers/marvell/uart/a3700_console.S
drivers/marvell/uart/a3700_console.h [deleted file]
include/drivers/marvell/uart/a3700_console.h [new file with mode: 0644]
include/plat/marvell/a3700/common/plat_marvell.h
include/plat/marvell/a8k/common/plat_marvell.h
plat/marvell/a3700/common/a3700_common.mk
plat/marvell/a8k/common/a8k_common.mk
plat/marvell/a8k/common/ble/ble.mk
plat/marvell/a8k/common/ble/ble_main.c
plat/marvell/a8k/common/plat_pm.c
plat/marvell/common/aarch64/marvell_helpers.S
plat/marvell/common/marvell_bl1_setup.c
plat/marvell/common/marvell_bl2_setup.c
plat/marvell/common/marvell_bl31_setup.c
plat/marvell/common/marvell_common.mk
plat/marvell/common/marvell_console.c [new file with mode: 0644]

index 6575af47f43c295bcc316f11ad63da35ce6560a6..25c21cfcd8e1491ed86fc5647a15aa9d0c213e48 100644 (file)
@@ -5,16 +5,27 @@
  * https://spdx.org/licenses
  */
 
+#include <arch.h>
 #include <asm_macros.S>
 #include <a3700_console.h>
+#define USE_FINISH_CONSOLE_REG_2
+#include <console_macros.S>
 
-       .globl  console_core_init
-       .globl  console_core_putc
-       .globl  console_core_getc
-       .globl  console_core_flush
+       /*
+        * "core" functions are low-level implementations that don't require
+        * writable memory and are thus safe to call in BL1 crash context.
+        */
+       .globl console_a3700_core_putc
+       .globl console_a3700_core_init
+       .globl console_a3700_core_getc
+       .globl console_a3700_core_flush
+
+       .globl console_a3700_putc
+       .globl console_a3700_getc
+       .globl console_a3700_flush
 
        /* -----------------------------------------------
-        * int console_core_init(unsigned long base_addr,
+        * int console_a3700_core_init(unsigned long base_addr,
         * unsigned int uart_clk, unsigned int baud_rate)
         * Function to initialize the console without a
         * C Runtime to print debug information. This
@@ -27,7 +38,7 @@
         * Clobber list : x1, x2, x3
         * -----------------------------------------------
         */
-func console_core_init
+func console_a3700_core_init
        /* Check the input base address */
        cbz     x0, init_fail
        /* Check baud rate and uart clock for sanity */
@@ -95,10 +106,43 @@ func console_core_init
 init_fail:
        mov     w0, #0
        ret
-endfunc console_core_init
+endfunc console_a3700_core_init
+
+       .globl console_a3700_register
+
+       /* -----------------------------------------------
+        * int console_a3700_register(console_16550_t *console,
+               uintptr_t base, uint32_t clk, uint32_t baud)
+        * Function to initialize and register a new a3700
+        * console. Storage passed in for the console struct
+        * *must* be persistent (i.e. not from the stack).
+        * In: x0 - UART register base address
+        *     w1 - UART clock in Hz
+        *     w2 - Baud rate
+        *     x3 - pointer to empty console_a3700_t struct
+        * Out: return 1 on success, 0 on error
+        * Clobber list : x0, x1, x2, x6, x7, x14
+        * -----------------------------------------------
+        */
+func console_a3700_register
+       mov     x7, x30
+       mov     x6, x3
+       cbz     x6, register_fail
+       str     x0, [x6, #CONSOLE_T_A3700_BASE]
+
+       bl      console_a3700_core_init
+       cbz     x0, register_fail
+
+       mov     x0, x6
+       mov     x30, x7
+       finish_console_register a3700, putc=1, getc=1, flush=1
+
+register_fail:
+       ret     x7
+endfunc console_a3700_register
 
        /* --------------------------------------------------------
-        * int console_core_putc(int c, unsigned int base_addr)
+        * int console_a3700_core_putc(int c, unsigned int base_addr)
         * Function to output a character over the console. It
         * returns the character printed on success or -1 on error.
         * In : w0 - character to be printed
@@ -107,7 +151,7 @@ endfunc console_core_init
         * Clobber list : x2
         * --------------------------------------------------------
         */
-func console_core_putc
+func console_a3700_core_putc
        /* Check the input parameter */
        cbz     x1, putc_error
 
@@ -132,10 +176,25 @@ func console_core_putc
 putc_error:
        mov     w0, #-1
        ret
-endfunc console_core_putc
+endfunc console_a3700_core_putc
+
+       /* --------------------------------------------------------
+        * int console_a3700_putc(int c, console_a3700_t *console)
+        * Function to output a character over the console. It
+        * returns the character printed on success or -1 on error.
+        * In : w0 - character to be printed
+        *      x1 - pointer to console_t structure
+        * Out : return -1 on error else return character.
+        * Clobber list : x2
+        * --------------------------------------------------------
+        */
+func console_a3700_putc
+       ldr     x1, [x1, #CONSOLE_T_A3700_BASE]
+       b       console_a3700_core_putc
+endfunc console_a3700_putc
 
        /* ---------------------------------------------
-        * int console_core_getc(void)
+        * int console_a3700_core_getc(void)
         * Function to get a character from the console.
         * It returns the character grabbed on success
         * or -1 on error.
@@ -144,16 +203,28 @@ endfunc console_core_putc
         * Clobber list : x0, x1
         * ---------------------------------------------
         */
-func console_core_getc
-       /* Check if the receive FIFO is empty */
-       ret
-getc_error:
+func console_a3700_core_getc
        mov     w0, #-1
        ret
-endfunc console_core_getc
+endfunc console_a3700_core_getc
+
+       /* ---------------------------------------------
+        * int console_a3700_getc(console_a3700_t *console)
+        * Function to get a character from the console.
+        * It returns the character grabbed on success
+        * or -1 on if no character is available.
+        * In :  x0 - pointer to console_t structure
+        * Out : w0 - character if available, else -1
+        * Clobber list : x0, x1
+        * ---------------------------------------------
+        */
+func console_a3700_getc
+       ldr     x0, [x0, #CONSOLE_T_A3700_BASE]
+       b       console_a3700_core_getc
+endfunc console_a3700_getc
 
        /* ---------------------------------------------
-        * int console_core_flush(uintptr_t base_addr)
+        * int console_a3700_core_flush(uintptr_t base_addr)
         * Function to force a write of all buffered
         * data that hasn't been output.
         * In : x0 - console base address
@@ -161,8 +232,22 @@ endfunc console_core_getc
         * Clobber list : x0, x1
         * ---------------------------------------------
         */
-func console_core_flush
-       /* Placeholder */
+func console_a3700_core_flush
        mov     w0, #0
        ret
-endfunc console_core_flush
+endfunc console_a3700_core_flush
+
+       /* ---------------------------------------------
+        * int console_a3700_flush(console_a3700_t *console)
+        * Function to force a write of all buffered
+        * data that hasn't been output.
+        * In : x0 - pointer to console_t structure
+        * Out : return -1 on error else return 0.
+        * Clobber list : x0, x1
+        * ---------------------------------------------
+        */
+func console_a3700_flush
+       ldr     x0, [x0, #CONSOLE_T_A3700_BASE]
+       b       console_a3700_core_flush
+endfunc console_a3700_flush
+
diff --git a/drivers/marvell/uart/a3700_console.h b/drivers/marvell/uart/a3700_console.h
deleted file mode 100644 (file)
index de7c4fc..0000000
+++ /dev/null
@@ -1,55 +0,0 @@
-/*
- * Copyright (C) 2016 Marvell International Ltd.
- *
- * SPDX-License-Identifier:    BSD-3-Clause
- * https://spdx.org/licenses
- */
-
-#ifndef A3700_CONSOLE_H
-#define A3700_CONSOLE_H
-
-/* MVEBU UART Registers */
-#define UART_RX_REG            0x00
-#define UART_TX_REG            0x04
-#define UART_CTRL_REG          0x08
-#define UART_STATUS_REG                0x0c
-#define UART_BAUD_REG          0x10
-#define UART_POSSR_REG         0x14
-
-/* FIFO Control Register bits */
-#define UARTFCR_FIFOMD_16450   (0 << 6)
-#define UARTFCR_FIFOMD_16550   (1 << 6)
-#define UARTFCR_RXTRIG_1       (0 << 6)
-#define UARTFCR_RXTRIG_4       (1 << 6)
-#define UARTFCR_RXTRIG_8       (2 << 6)
-#define UARTFCR_RXTRIG_16      (3 << 6)
-#define UARTFCR_TXTRIG_1       (0 << 4)
-#define UARTFCR_TXTRIG_4       (1 << 4)
-#define UARTFCR_TXTRIG_8       (2 << 4)
-#define UARTFCR_TXTRIG_16      (3 << 4)
-#define UARTFCR_DMAEN          (1 << 3)        /* Enable DMA mode */
-#define UARTFCR_TXCLR          (1 << 2)        /* Clear contents of Tx FIFO */
-#define UARTFCR_RXCLR          (1 << 1)        /* Clear contents of Rx FIFO */
-#define UARTFCR_FIFOEN         (1 << 0)        /* Enable the Tx/Rx FIFO */
-
-/* Line Control Register bits */
-#define UARTLCR_DLAB           (1 << 7)        /* Divisor Latch Access */
-#define UARTLCR_SETB           (1 << 6)        /* Set BREAK Condition */
-#define UARTLCR_SETP           (1 << 5)        /* Set Parity to LCR[4] */
-#define UARTLCR_EVEN           (1 << 4)        /* Even Parity Format */
-#define UARTLCR_PAR            (1 << 3)        /* Parity */
-#define UARTLCR_STOP           (1 << 2)        /* Stop Bit */
-#define UARTLCR_WORDSZ_5       0               /* Word Length of 5 */
-#define UARTLCR_WORDSZ_6       1               /* Word Length of 6 */
-#define UARTLCR_WORDSZ_7       2               /* Word Length of 7 */
-#define UARTLCR_WORDSZ_8       3               /* Word Length of 8 */
-
-/* Line Status Register bits */
-#define UARTLSR_TXFIFOFULL     (1 << 11)       /* Tx Fifo Full */
-
-/* UART Control Register bits */
-#define UART_CTRL_RXFIFO_RESET (1 << 14)
-#define UART_CTRL_TXFIFO_RESET (1 << 15)
-#define UARTLSR_TXFIFOEMPTY    (1 << 6)
-
-#endif /* A3700_CONSOLE_H */
diff --git a/include/drivers/marvell/uart/a3700_console.h b/include/drivers/marvell/uart/a3700_console.h
new file mode 100644 (file)
index 0000000..01335a2
--- /dev/null
@@ -0,0 +1,79 @@
+/*
+ * Copyright (C) 2016 Marvell International Ltd.
+ *
+ * SPDX-License-Identifier:    BSD-3-Clause
+ * https://spdx.org/licenses
+ */
+
+#ifndef A3700_CONSOLE_H
+#define A3700_CONSOLE_H
+
+#include <console.h>
+
+/* MVEBU UART Registers */
+#define UART_RX_REG            0x00
+#define UART_TX_REG            0x04
+#define UART_CTRL_REG          0x08
+#define UART_STATUS_REG                0x0c
+#define UART_BAUD_REG          0x10
+#define UART_POSSR_REG         0x14
+
+/* FIFO Control Register bits */
+#define UARTFCR_FIFOMD_16450   (0 << 6)
+#define UARTFCR_FIFOMD_16550   (1 << 6)
+#define UARTFCR_RXTRIG_1       (0 << 6)
+#define UARTFCR_RXTRIG_4       (1 << 6)
+#define UARTFCR_RXTRIG_8       (2 << 6)
+#define UARTFCR_RXTRIG_16      (3 << 6)
+#define UARTFCR_TXTRIG_1       (0 << 4)
+#define UARTFCR_TXTRIG_4       (1 << 4)
+#define UARTFCR_TXTRIG_8       (2 << 4)
+#define UARTFCR_TXTRIG_16      (3 << 4)
+#define UARTFCR_DMAEN          (1 << 3)        /* Enable DMA mode */
+#define UARTFCR_TXCLR          (1 << 2)        /* Clear contents of Tx FIFO */
+#define UARTFCR_RXCLR          (1 << 1)        /* Clear contents of Rx FIFO */
+#define UARTFCR_FIFOEN         (1 << 0)        /* Enable the Tx/Rx FIFO */
+
+/* Line Control Register bits */
+#define UARTLCR_DLAB           (1 << 7)        /* Divisor Latch Access */
+#define UARTLCR_SETB           (1 << 6)        /* Set BREAK Condition */
+#define UARTLCR_SETP           (1 << 5)        /* Set Parity to LCR[4] */
+#define UARTLCR_EVEN           (1 << 4)        /* Even Parity Format */
+#define UARTLCR_PAR            (1 << 3)        /* Parity */
+#define UARTLCR_STOP           (1 << 2)        /* Stop Bit */
+#define UARTLCR_WORDSZ_5       0               /* Word Length of 5 */
+#define UARTLCR_WORDSZ_6       1               /* Word Length of 6 */
+#define UARTLCR_WORDSZ_7       2               /* Word Length of 7 */
+#define UARTLCR_WORDSZ_8       3               /* Word Length of 8 */
+
+/* Line Status Register bits */
+#define UARTLSR_TXFIFOFULL     (1 << 11)       /* Tx Fifo Full */
+
+/* UART Control Register bits */
+#define UART_CTRL_RXFIFO_RESET (1 << 14)
+#define UART_CTRL_TXFIFO_RESET (1 << 15)
+#define UARTLSR_TXFIFOEMPTY    (1 << 6)
+
+#define CONSOLE_T_A3700_BASE   CONSOLE_T_DRVDATA
+
+#ifndef __ASSEMBLY__
+
+#include <stdint.h>
+
+typedef struct {
+       console_t console;
+       uintptr_t base;
+} console_a3700_t;
+
+/*
+ * Initialize a new a3700 console instance and register it with the console
+ * framework. The |console| pointer must point to storage that will be valid
+ * for the lifetime of the console, such as a global or static local variable.
+ * Its contents will be reinitialized from scratch.
+ */
+int console_a3700_register(uintptr_t baseaddr, uint32_t clock, uint32_t baud,
+                          console_a3700_t *console);
+
+#endif /*__ASSEMBLY__*/
+
+#endif /* A3700_CONSOLE_H */
index 8c289e9879dc3b12108c1e6dc927f626102d1cc3..01e42c545d699d641b465650217ec218489a2080 100644 (file)
@@ -39,6 +39,12 @@ void marvell_setup_page_tables(uintptr_t total_base,
 #endif
 );
 
+/* Console utility functions */
+void marvell_console_boot_init(void);
+void marvell_console_boot_end(void);
+void marvell_console_runtime_init(void);
+void marvell_console_runtime_end(void);
+
 /* IO storage utility functions */
 void marvell_io_setup(void);
 
index f062491f9150df6e58ba3f2884e3774c777f1e64..037548da063f1234c46a9d1cded1e8bb3d127820 100644 (file)
@@ -48,6 +48,12 @@ void marvell_setup_page_tables(uintptr_t total_base,
 #endif
 );
 
+/* Console utility functions */
+void marvell_console_boot_init(void);
+void marvell_console_boot_end(void);
+void marvell_console_runtime_init(void);
+void marvell_console_runtime_end(void);
+
 /* IO storage utility functions */
 void marvell_io_setup(void);
 
index 387562bcbb9c77acf9b9caff629fcba9382c5f3d..3983c707c0c0cfae3e34f7aa2bb853be9e695292 100644 (file)
@@ -71,7 +71,6 @@ TIMBLDUARTARGS                := $(MARVELL_SECURE_BOOT) UART $(IMAGESPATH) $(DOIMAGEPATH) $(CL
                                $(DDR_TOPOLOGY) 0 0 $(DOIMAGE_CFG) $(TIMNCFG) $(TIMNSIG) 0
 DOIMAGE_FLAGS          := -r $(DOIMAGE_CFG) -v -D
 
-
 # GICV3
 $(eval $(call add_define,CONFIG_GICV3))
 
@@ -91,8 +90,8 @@ ATF_INCLUDES          :=      -Iinclude/common/tbbr           \
 PLAT_INCLUDES          :=      -I$(PLAT_FAMILY_BASE)/$(PLAT)           \
                                -I$(PLAT_COMMON_BASE)/include           \
                                -I$(PLAT_INCLUDE_BASE)/common           \
-                               -I$(MARVELL_DRV_BASE)/uart              \
                                -I$(MARVELL_DRV_BASE)                   \
+                               -Iinclude/drivers/marvell/uart          \
                                -I$/drivers/arm/gic/common/             \
                                $(ATF_INCLUDES)
 
index a589004bd517ee1416d7ea62dc35493162e1d59e..6136a1f596685d0222dcf9dba4be7457c0bcbf69 100644 (file)
@@ -25,7 +25,6 @@ $(eval $(call add_define,BL31_CACHE_DISABLE))
 $(eval $(call add_define,PCI_EP_SUPPORT))
 $(eval $(call assert_boolean,PCI_EP_SUPPORT))
 
-
 AP_NUM                 := 1
 $(eval $(call add_define,AP_NUM))
 
index a76083ebfc080fc57ec4fb08c046df426c1fecd3..5f24ced23b5a54e79f837057051a2280c41e2e09 100644 (file)
@@ -12,8 +12,9 @@ PLAT_MARVELL          =       plat/marvell
 
 BLE_SOURCES            +=      $(BLE_PATH)/ble_main.c                          \
                                $(BLE_PATH)/ble_mem.S                           \
-                               drivers/delay_timer/delay_timer.c       \
-                               $(PLAT_MARVELL)/common/plat_delay_timer.c
+                               drivers/delay_timer/delay_timer.c               \
+                               $(PLAT_MARVELL)/common/plat_delay_timer.c       \
+                               $(PLAT_MARVELL)/common/marvell_console.c
 
 PLAT_INCLUDES          +=      -I$(MV_DDR_PATH) \
                                -I$(CURDIR)/include/ \
index e52c738d3295a0606b28aa260561988846889436..b04e8b7a666e888cd75f7c408857be50b30b9841 100644 (file)
@@ -35,13 +35,11 @@ int exec_ble_main(int bootrom_flags)
         * initialize the console and prints will be ignored
         */
        if ((bootrom_flags & BR_FLAG_SILENT) == 0)
-               console_init(PLAT_MARVELL_BOOT_UART_BASE,
-                            PLAT_MARVELL_BOOT_UART_CLK_IN_HZ,
-                            MARVELL_CONSOLE_BAUDRATE);
+               marvell_console_boot_init();
 
        NOTICE("Starting binary extension\n");
 
-       /* initiliaze time (for delay functionality) */
+       /* initialize time (for delay functionality) */
        plat_delay_timer_init();
 
        ble_plat_setup(&skip);
index 0c74b2fe55d5b7d509e3f4c7196d3328515909f3..1b68d0767eaa7fc550cab781da98a8bb3ff77e00 100644 (file)
@@ -19,7 +19,6 @@
 #include <plat_marvell.h>
 #include <platform.h>
 #include <plat_pm_trace.h>
-#include <platform.h>
 
 #define MVEBU_PRIVATE_UID_REG          0x30
 #define MVEBU_RFU_GLOBL_SW_RST         0x84
@@ -614,6 +613,8 @@ static void a8k_pwr_domain_suspend(const psci_power_state_t *target_state)
 
                INFO("Suspending to RAM\n");
 
+               marvell_console_runtime_end();
+
                /* Prevent interrupts from spuriously waking up this cpu */
                gicv2_cpuif_disable();
 
@@ -687,9 +688,7 @@ static void a8k_pwr_domain_suspend_finish(
                        /* Initialize the console to provide
                         * early debug support
                         */
-                       console_init(PLAT_MARVELL_BOOT_UART_BASE,
-                       PLAT_MARVELL_BOOT_UART_CLK_IN_HZ,
-                       MARVELL_CONSOLE_BAUDRATE);
+                       marvell_console_runtime_init();
 
                        bl31_plat_arch_setup();
                        marvell_bl31_platform_setup();
index 128c3ab69e1017de6962d23e2f26b73e0d03b2e6..fbd19cb612f25d7e7fdb30738acba1c90da11e32 100644 (file)
@@ -65,7 +65,11 @@ func plat_crash_console_init
        mov_imm x0, PLAT_MARVELL_CRASH_UART_BASE
        mov_imm x1, PLAT_MARVELL_CRASH_UART_CLK_IN_HZ
        mov_imm x2, MARVELL_CONSOLE_BAUDRATE
-       b       console_core_init
+#ifdef PLAT_a3700
+       b       console_a3700_core_init
+#else
+       b       console_16550_core_init
+#endif
 endfunc plat_crash_console_init
 
        /* ---------------------------------------------
@@ -77,7 +81,12 @@ endfunc plat_crash_console_init
         */
 func plat_crash_console_putc
        mov_imm x1, PLAT_MARVELL_CRASH_UART_BASE
-       b       console_core_putc
+#ifdef PLAT_a3700
+
+       b       console_a3700_core_putc
+#else
+       b       console_16550_core_putc
+#endif
 endfunc plat_crash_console_putc
 
        /* ---------------------------------------------
@@ -85,12 +94,16 @@ endfunc plat_crash_console_putc
         * Function to force a write of all buffered
         * data that hasn't been output.
         * Out : return -1 on error else return 0.
-        * Clobber list : x0, x1
+        * Clobber list : r0
         * ---------------------------------------------
         */
 func plat_crash_console_flush
        mov_imm x0, PLAT_MARVELL_CRASH_UART_BASE
-       b       console_core_flush
+#ifdef PLAT_a3700
+       b       console_a3700_core_flush
+#else
+       b       console_16550_core_flush
+#endif
 endfunc plat_crash_console_flush
 
        /* ---------------------------------------------------------------------
index 4e1b256b04a746f9efd30f73f06176d505d68bfd..c96f00679df800fac4c986004076c640a394038a 100644 (file)
@@ -35,9 +35,7 @@ meminfo_t *bl1_plat_sec_mem_layout(void)
 void marvell_bl1_early_platform_setup(void)
 {
        /* Initialize the console to provide early debug support */
-       console_init(PLAT_MARVELL_BOOT_UART_BASE,
-                    PLAT_MARVELL_BOOT_UART_CLK_IN_HZ,
-                    MARVELL_CONSOLE_BAUDRATE);
+       marvell_console_boot_init();
 
        /* Allow BL1 to see the whole Trusted RAM */
        bl1_ram_layout.total_base = MARVELL_BL_RAM_BASE;
index d33aba477e974b23076abe34c56101c15502e104..883336f0da76cc9604a65910c3157a65d27c3538 100644 (file)
@@ -40,9 +40,7 @@ meminfo_t *bl2_plat_sec_mem_layout(void)
 void marvell_bl2_early_platform_setup(meminfo_t *mem_layout)
 {
        /* Initialize the console to provide early debug support */
-       console_init(PLAT_MARVELL_BOOT_UART_BASE,
-                    PLAT_MARVELL_BOOT_UART_CLK_IN_HZ,
-                    MARVELL_CONSOLE_BAUDRATE);
+       marvell_console_boot_init();
 
        /* Setup the BL2 memory layout */
        bl2_tzram_layout = *mem_layout;
index da91b56077b052ccc0b7bb2641c8a982c2d33988..3b1a6f130cf247ccef6b5cdd02c1555fe71cb165 100644 (file)
@@ -74,9 +74,7 @@ void marvell_bl31_early_platform_setup(void *from_bl2,
                                       void *plat_params_from_bl2)
 {
        /* Initialize the console to provide early debug support */
-       console_init(PLAT_MARVELL_BOOT_UART_BASE,
-                    PLAT_MARVELL_BOOT_UART_CLK_IN_HZ,
-                    MARVELL_CONSOLE_BAUDRATE);
+       marvell_console_boot_init();
 
 #if RESET_TO_BL31
        /* There are no parameters from BL2 if BL31 is a reset vector */
@@ -190,10 +188,10 @@ void marvell_bl31_platform_setup(void)
  */
 void marvell_bl31_plat_runtime_setup(void)
 {
+       console_switch_state(CONSOLE_FLAG_RUNTIME);
+
        /* Initialize the runtime console */
-       console_init(PLAT_MARVELL_BL31_RUN_UART_BASE,
-                    PLAT_MARVELL_BL31_RUN_UART_CLK_IN_HZ,
-                    MARVELL_CONSOLE_BAUDRATE);
+       marvell_console_runtime_init();
 }
 
 void bl31_platform_setup(void)
index 3a6bb0339b9d6dec2493d54aa2bd27058dfb61e5..fb6fbb5859b8751fa7e4ad5f5868ea3ffaf438f3 100644 (file)
@@ -11,6 +11,8 @@ include $(MARVELL_PLAT_BASE)/marvell.mk
 
 VERSION_STRING                 +=(Marvell-${SUBVERSION})
 
+MULTI_CONSOLE_API              := 1
+
 SEPARATE_CODE_AND_RODATA       := 1
 
 # flag to switch from PLL to ARO
@@ -28,7 +30,8 @@ PLAT_INCLUDES         +=      -I. -Iinclude/common -Iinclude/common/tbbr      \
 PLAT_BL_COMMON_SOURCES  +=      lib/xlat_tables/xlat_tables_common.c                   \
                                lib/xlat_tables/aarch64/xlat_tables.c                   \
                                $(MARVELL_PLAT_BASE)/common/aarch64/marvell_common.c    \
-                               $(MARVELL_PLAT_BASE)/common/aarch64/marvell_helpers.S
+                               $(MARVELL_PLAT_BASE)/common/aarch64/marvell_helpers.S   \
+                               $(MARVELL_COMMON_BASE)/marvell_console.c
 
 BL1_SOURCES            +=      drivers/delay_timer/delay_timer.c                       \
                                drivers/io/io_fip.c                                     \
diff --git a/plat/marvell/common/marvell_console.c b/plat/marvell/common/marvell_console.c
new file mode 100644 (file)
index 0000000..eba106d
--- /dev/null
@@ -0,0 +1,86 @@
+/*
+ * Copyright (c) 2018, ARM Limited and Contributors. All rights reserved.
+ *
+ * SPDX-License-Identifier: BSD-3-Clause
+ */
+#include <assert.h>
+#include <console.h>
+#include <debug.h>
+#include <plat_marvell.h>
+#include <platform_def.h>
+
+#ifdef PLAT_a3700
+#include <a3700_console.h>
+
+static console_a3700_t marvell_boot_console;
+static console_a3700_t marvell_runtime_console;
+#else
+#include <uart_16550.h>
+
+static console_16550_t marvell_boot_console;
+static console_16550_t marvell_runtime_console;
+#endif
+
+/*******************************************************************************
+ * Functions that set up the console
+ ******************************************************************************/
+
+/* Initialize the console to provide early debug support */
+void marvell_console_boot_init(void)
+{
+       int rc =
+#ifdef PLAT_a3700
+       console_a3700_register(
+#else
+       console_16550_register(
+#endif
+                               PLAT_MARVELL_BOOT_UART_BASE,
+                               PLAT_MARVELL_BOOT_UART_CLK_IN_HZ,
+                               MARVELL_CONSOLE_BAUDRATE,
+                               &marvell_boot_console);
+       if (rc == 0) {
+               /*
+                * The crash console doesn't use the multi console API, it uses
+                * the core console functions directly. It is safe to call panic
+                * and let it print debug information.
+                */
+               panic();
+       }
+
+       console_set_scope(&marvell_boot_console.console,
+                         CONSOLE_FLAG_BOOT);
+}
+
+void marvell_console_boot_end(void)
+{
+       (void)console_flush();
+
+       (void)console_unregister(&marvell_boot_console.console);
+}
+
+/* Initialize the runtime console */
+void marvell_console_runtime_init(void)
+{
+       int rc =
+#ifdef PLAT_a3700
+       console_a3700_register(
+#else
+       console_16550_register(
+#endif
+                               PLAT_MARVELL_BOOT_UART_BASE,
+                               PLAT_MARVELL_BOOT_UART_CLK_IN_HZ,
+                               MARVELL_CONSOLE_BAUDRATE,
+                               &marvell_runtime_console);
+       if (rc == 0)
+               panic();
+
+       console_set_scope(&marvell_runtime_console.console,
+                         CONSOLE_FLAG_RUNTIME);
+}
+
+void marvell_console_runtime_end(void)
+{
+       (void)console_flush();
+
+       (void)console_unregister(&marvell_runtime_console.console);
+}